Changes in / [8605361:34e505f]

Location:

src

Files:

• io/sink_apple_audio.c (modified) (2 diffs)
• io/source_apple_audio.c (modified) (2 diffs)
• io/utils_apple_audio.c (modified) (1 diff)
• pitch/pitchmcomb.c (modified) (2 diffs)
• tempo/beattracking.c (modified) (1 diff)
• tempo/beattracking.h (modified) (1 diff)
• tempo/tempo.c (modified) (6 diffs)
• tempo/tempo.h (modified) (2 diffs)

src/io/sink_apple_audio.c

@@ -37 +37 @@
 extern int createAubioBufferList(AudioBufferList *bufferList, int channels, int segmentSize);
 extern void freeAudioBufferList(AudioBufferList *bufferList);
-extern CFURLRef createURLFromPath(const char * path);
+extern CFURLRef getURLFromPath(const char * path);
 char_t *getPrintableOSStatusError(char_t *str, OSStatus error);
 
@@ -138 +138 @@
 
   AudioFileTypeID fileType = kAudioFileWAVEType;
-  CFURLRef fileURL = createURLFromPath(s->path);
+  CFURLRef fileURL = getURLFromPath(s->path);
   bool overwrite = true;
   OSStatus err = noErr;
   err = ExtAudioFileCreateWithURL(fileURL, fileType, &clientFormat, NULL,
      overwrite ? kAudioFileFlags_EraseFile : 0, &s->audioFile);
-  CFRelease(fileURL);
   if (err) {
     char_t errorstr[20];

src/io/source_apple_audio.c

@@ -52 +52 @@
 extern int createAubioBufferList(AudioBufferList *bufferList, int channels, int max_source_samples);
 extern void freeAudioBufferList(AudioBufferList *bufferList);
-extern CFURLRef createURLFromPath(const char * path);
+extern CFURLRef getURLFromPath(const char * path);
 char_t *getPrintableOSStatusError(char_t *str, OSStatus error);
 
@@ -99 +99 @@
 
   // open the resource url
-  CFURLRef fileURL = createURLFromPath(path);
+  CFURLRef fileURL = getURLFromPath(path);
   err = ExtAudioFileOpenURL(fileURL, &s->audioFile);
-  CFRelease(fileURL);
   if (err == -43) {
     AUBIO_ERR("source_apple_audio: Failed opening %s, "

src/io/utils_apple_audio.c

@@ -34 +34 @@
 }
 
-CFURLRef createURLFromPath(const char * path) {
+CFURLRef getURLFromPath(const char * path) {
   CFStringRef cfTotalPath = CFStringCreateWithCString (kCFAllocatorDefault,
       path, kCFStringEncodingUTF8);
 
-  CFURLRef url = CFURLCreateWithFileSystemPath(kCFAllocatorDefault, cfTotalPath,
+  return CFURLCreateWithFileSystemPath(kCFAllocatorDefault, cfTotalPath,
       kCFURLPOSIXPathStyle, false);
-  CFRelease(cfTotalPath);
-  return url;
 }
 

src/pitch/pitchmcomb.c

@@ -336 +336 @@
   uint_t run = 0;
   for (cur = 0; cur < nbins; cur++) {
-    for (run = cur + 1; run < nbins; run++) {
+    run = cur + 1;
+    for (run = cur; run < nbins; run++) {
       if (candidates[run]->ene > candidates[cur]->ene)
         CAND_SWAP (candidates[run], candidates[cur]);
@@ -351 +352 @@
   uint_t run = 0;
   for (cur = 0; cur < nbins; cur++) {
-    for (run = cur + 1; run < nbins; run++) {
+    run = cur + 1;
+    for (run = cur; run < nbins; run++) {
       if (candidates[run]->ebin < candidates[cur]->ebin)
         CAND_SWAP (candidates[run], candidates[cur]);

src/tempo/beattracking.c

@@ -410 +410 @@
 
 smpl_t
-aubio_beattracking_get_period (aubio_beattracking_t * bt)
-{
-  return bt->hop_size * bt->bp;
-}
-
-smpl_t
-aubio_beattracking_get_period_s (aubio_beattracking_t * bt)
-{
-  return aubio_beattracking_get_period(bt) / (smpl_t) bt->samplerate;
-}
-
-smpl_t
 aubio_beattracking_get_bpm (aubio_beattracking_t * bt)
 {
   if (bt->bp != 0) {
-    return 60. / aubio_beattracking_get_period_s(bt);
+    return 60. * bt->samplerate/ bt->bp / bt->hop_size;
   } else {
     return 0.;

src/tempo/beattracking.h

@@ -68 +68 @@
     fvec_t * out);
 
-/** get current beat period in samples
-
-  \param bt beat tracking object
-
-  Returns the currently observed period, in samples, or 0 if no consistent
-  value is found.
-
-*/
-smpl_t aubio_beattracking_get_period (aubio_beattracking_t * bt);
-
-/** get current beat period in seconds
-
-  \param bt beat tracking object
-
-  Returns the currently observed period, in seconds, or 0 if no consistent
-  value is found.
-
-*/
-smpl_t aubio_beattracking_get_period_s (aubio_beattracking_t * bt);
-
 /** get current tempo in bpm
 

src/tempo/tempo.c

@@ -65 +65 @@
   sint_t blockpos;               /** current position in dfframe */
   uint_t winlen;                 /** dfframe bufsize */
-  uint_t step;                   /** dfframe hopsize */
-  uint_t samplerate;             /** sampling rate of the signal */
+  uint_t step;                   /** dfframe hopsize */ 
+  uint_t samplerate;             /** sampling rate of the signal */ 
   uint_t hop_size;               /** get hop_size */
   uint_t total_frames;           /** total frames since beginning */
   uint_t last_beat;              /** time of latest detected beat, in samples */
   uint_t delay;                  /** delay to remove to last beat, in samples */
-  uint_t last_tatum;             /** time of latest detected tatum, in samples */
-  uint_t tatum_signature;        /** number of tatum between each beats */
 };
 
@@ -93 +91 @@
     aubio_beattracking_do(o->bt,o->dfframe,o->out);
     /* rotate dfframe */
-    for (i = 0 ; i < winlen - step; i++ )
+    for (i = 0 ; i < winlen - step; i++ ) 
       o->dfframe->data[i] = o->dfframe->data[i+step];
-    for (i = winlen - step ; i < winlen; i++ )
+    for (i = winlen - step ; i < winlen; i++ ) 
       o->dfframe->data[i] = 0.;
     o->blockpos = -1;
@@ -106 +104 @@
   /* end of second level loop */
   tempo->data[0] = 0; /* reset tactus */
-  //i=0;
+  i=0;
   for (i = 1; i < o->out->data[0]; i++ ) {
     /* if current frame is a predicted tactus */
@@ -116 +114 @@
       }
       o->last_beat = o->total_frames + (uint_t)ROUND(tempo->data[0] * o->hop_size);
-      o->last_tatum = o->last_beat;
     }
   }
@@ -218 +215 @@
     onset2 = new_fvec(1);
   }*/
-  o->last_tatum = 0;
-  o->tatum_signature = 4;
   return o;
 
@@ -231 +226 @@
 }
 
-smpl_t aubio_tempo_get_period (aubio_tempo_t *o)
-{
-  return aubio_beattracking_get_period (o->bt);
-}
-
-smpl_t aubio_tempo_get_period_s (aubio_tempo_t *o)
-{
-  return aubio_beattracking_get_period_s (o->bt);
-}
-
 smpl_t aubio_tempo_get_confidence(aubio_tempo_t *o) {
   return aubio_beattracking_get_confidence(o->bt);
-}
-
-uint_t aubio_tempo_was_tatum (aubio_tempo_t *o)
-{
-  uint_t last_tatum_distance = o->total_frames - o->last_tatum;
-  smpl_t beat_period = aubio_tempo_get_period(o);
-  smpl_t tatum_period = beat_period / o->tatum_signature;
-  if (last_tatum_distance < o->hop_size) {
-    o->last_tatum = o->last_beat;
-    return 2;
-  }
-  else if (last_tatum_distance > tatum_period) {
-    if ( last_tatum_distance + o->hop_size > beat_period ) {
-      // next beat is too close, pass
-      return 0;
-    }
-    o->last_tatum = o->total_frames;
-    return 1;
-  }
-  return 0;
-}
-
-smpl_t aubio_tempo_get_last_tatum (aubio_tempo_t *o) {
-  return (smpl_t)o->last_tatum - o->delay;
-}
-
-uint_t aubio_tempo_set_tatum_signature (aubio_tempo_t *o, uint_t signature) {
-  if (signature < 1 || signature > 64) {
-    return AUBIO_FAIL;
-  } else {
-    o->tatum_signature = signature;
-    return AUBIO_OK;
-  }
 }
 

src/tempo/tempo.h

@@ -122 +122 @@
 smpl_t aubio_tempo_get_threshold(aubio_tempo_t * o);
 
-/** get current beat period in samples
-
-  \param bt beat tracking object
-
-  Returns the currently observed period, in samples, or 0 if no consistent
-  value is found.
-
-*/
-smpl_t aubio_tempo_get_period (aubio_tempo_t * bt);
-
-/** get current beat period in seconds
-
-  \param bt beat tracking object
-
-  Returns the currently observed period, in seconds, or 0 if no consistent
-  value is found.
-
-*/
-smpl_t aubio_tempo_get_period_s (aubio_tempo_t * bt);
-
 /** get current tempo
 
@@ -161 +141 @@
 smpl_t aubio_tempo_get_confidence(aubio_tempo_t * o);
 
-/* set number of tatum per beat
-
-   \param o beat tracking object
-   \param signature number of tatum per beat (between 1 and 64)
-
-*/
-uint_t aubio_tempo_set_tatum_signature(aubio_tempo_t *o, uint_t signature);
-
-/* check whether a tatum was detected in the current frame
-
-   \param o beat tracking object
-
-   \return 2 if a beat was detected, 1 if a tatum was detected, 0 otherwise
-
-*/
-uint_t aubio_tempo_was_tatum(aubio_tempo_t *o);
-
-/* get position of last_tatum, in samples
-
-   \param o beat tracking object
-
-*/
-smpl_t aubio_tempo_get_last_tatum(aubio_tempo_t *o);
-
 /** delete tempo detection object