Changeset 66fff6c


Ignore:
Timestamp:
May 6, 2019, 10:36:51 PM (5 months ago)
Author:
Paul Brossier <piem@piem.org>
Branches:
feature/autosink, feature/timestretch, master
Children:
3ed38e4
Parents:
f55630c
Message:

[py] use universal_newlines=True to prevent decoding errors (see gh-247 gh-248)

File:
1 edited

Legend:

Unmodified
Added
Removed
  • python/lib/gen_external.py

    rf55630c r66fff6c  
    121121    proc = subprocess.Popen(cpp_cmd,
    122122                            stderr=subprocess.PIPE,
    123                             stdout=subprocess.PIPE)
     123                            stdout=subprocess.PIPE,
     124                            universal_newlines=True)
    124125    assert proc, 'Proc was none'
    125126    cpp_output = proc.stdout.read()
     
    127128    if err_output:
    128129        print("Warning: preprocessor produced errors or warnings:\n%s" \
    129                 % err_output.decode('utf8'))
     130                % err_output)
    130131    if not cpp_output:
    131132        raise_msg = "preprocessor output is empty! Running command " \
    132133                + "\"%s\" failed" % " ".join(cpp_cmd)
    133134        if err_output:
    134             raise_msg += " with stderr: \"%s\"" % err_output.decode('utf8')
     135            raise_msg += " with stderr: \"%s\"" % err_output
    135136        else:
    136137            raise_msg += " with no stdout or stderr"
    137138        raise Exception(raise_msg)
    138139    if not isinstance(cpp_output, list):
    139         cpp_output = [l.strip() for l in cpp_output.decode('utf8').split('\n')]
     140        cpp_output = [l.strip() for l in cpp_output.split('\n')]
    140141
    141142    return cpp_output
Note: See TracChangeset for help on using the changeset viewer.