Changeset 77db425

Timestamp:

Nov 26, 2013, 4:18:57 AM (11 years ago)

Author:

Paul Brossier <piem@piem.org>

Branches:

feature/autosink, feature/cnn, feature/cnn_org, feature/constantq, feature/crepe, feature/crepe_org, feature/pitchshift, feature/pydocstrings, feature/timestretch, fix/ffmpeg5, master, pitchshift, sampler, timestretch, yinfft+

Children:

2dbcafa

Parents:

18f14f9

Message:

src/tempo/tempo.c: fix for different samplerates

Files:

• src/tempo/beattracking.c (modified) (3 diffs)
• src/tempo/beattracking.h (modified) (1 diff)
• src/tempo/tempo.c (modified) (2 diffs)
• tests/src/tempo/test-beattracking.c (modified) (1 diff)
• tests/src/tempo/test-tempo.c (modified) (2 diffs)

src/tempo/beattracking.c

@@ -32 +32 @@
 struct _aubio_beattracking_t
 {
+  uint_t hop_size;       /** length of one tempo detection function sample, in audio samples */
+  uint_t samplerate;     /** samplerate of the original signal */
   fvec_t *rwv;           /** rayleigh weighting for beat period in general model */
   fvec_t *dfwv;          /** exponential weighting for beat alignment in general model */
@@ -55 +57 @@
 
 aubio_beattracking_t *
-new_aubio_beattracking (uint_t winlen)
+new_aubio_beattracking (uint_t winlen, uint_t hop_size, uint_t samplerate)
 {
 
   aubio_beattracking_t *p = AUBIO_NEW (aubio_beattracking_t);
   uint_t i = 0;
-  /* parameter for rayleigh weight vector - sets preferred tempo to
-   * 120bpm [43] */
-  smpl_t rayparam = 48. / 512. * winlen;
+  p->hop_size = hop_size;
+  p->samplerate = samplerate;
+  /* default value for rayleigh weighting - sets preferred tempo to 120bpm */
+  smpl_t rayparam = 60. * samplerate / 120. / hop_size;
   smpl_t dfwvnorm = EXP ((LOG (2.0) / rayparam) * (winlen + 2));
   /* length over which beat period is found [128] */
@@ -415 +418 @@
 aubio_beattracking_get_bpm (aubio_beattracking_t * bt)
 {
-  if (bt->bp != 0 && bt->timesig != 0 && bt->counter == 0 && bt->flagstep == 0) {
-    return 5168. / fvec_quadratic_peak_pos (bt->acfout, bt->bp);
+  if (bt->bp != 0) {
+    return 60. * bt->samplerate/ bt->bp / bt->hop_size;
   } else {
     return 0.;

src/tempo/beattracking.h

@@ -52 +52 @@
 
 */
-aubio_beattracking_t * new_aubio_beattracking(uint_t hop_size);
+aubio_beattracking_t * new_aubio_beattracking(uint_t winlen, uint_t hop_size,
+    uint_t samplerate);
 
 /** track the beat 

src/tempo/tempo.c

@@ -142 +142 @@
   aubio_tempo_t * o = AUBIO_NEW(aubio_tempo_t);
   o->samplerate = samplerate;
-  o->winlen = SQR(512)/hop_size;
+  /* length of observations, worth about 6 seconds */
+  o->winlen = aubio_next_power_of_two(5.8 * samplerate / hop_size);
   o->step = o->winlen/4;
   o->blockpos = 0;
   o->threshold = 0.3;
   o->silence = -90.;
-  o->blockpos = 0;
   o->total_frames = 0;
   o->last_beat = 0;
@@ -160 +160 @@
   o->od       = new_aubio_specdesc(onset_mode,buf_size);
   o->of       = new_fvec(1);
-  o->bt       = new_aubio_beattracking(o->winlen);
+  o->bt       = new_aubio_beattracking(o->winlen, o->hop_size, o->samplerate);
   o->onset    = new_fvec(1);
   /*if (usedoubled)    {

tests/src/tempo/test-beattracking.c

@@ -12 +12 @@
 
   // create beattracking object
-  aubio_beattracking_t * tempo  = new_aubio_beattracking(win_s);
+  aubio_beattracking_t * tempo  = new_aubio_beattracking(win_s, 256, 44100);
 
   smpl_t bpm, confidence;

tests/src/tempo/test-tempo.c

@@ -9 +9 @@
     PRINT_ERR("not enough arguments\n");
     PRINT_MSG("read a wave file as a mono vector\n");
-    PRINT_MSG("usage: %s <source_path> [samplerate] [hop_size]\n", argv[0]);
+    PRINT_MSG("usage: %s <source_path> [samplerate] [win_size] [hop_size]\n", argv[0]);
     return err;
   }
   uint_t samplerate = 0;
-  uint_t win_s = 1024; // window size
-  uint_t hop_size = win_s / 4;
+  if ( argc >= 3 ) samplerate = atoi(argv[2]);
+  uint_t win_size = 1024; // window size
+  if ( argc >= 4 ) win_size = atoi(argv[3]);
+  uint_t hop_size = win_size / 4;
+  if ( argc >= 5 ) hop_size = atoi(argv[4]);
   uint_t n_frames = 0, read = 0;
-  if ( argc == 3 ) samplerate = atoi(argv[2]);
-  if ( argc == 4 ) hop_size = atoi(argv[3]);
 
   char_t *source_path = argv[1];
@@ -30 +31 @@
 
   // create tempo object
-  aubio_tempo_t * o = new_aubio_tempo("default", win_s, hop_size, samplerate);
+  aubio_tempo_t * o = new_aubio_tempo("default", win_size, hop_size, samplerate);
 
   do {