Changeset 7e204d01

Timestamp:

May 16, 2008, 12:50:38 AM (17 years ago)

Author:

Paul Brossier <piem@piem.org>

Branches:

feature/autosink, feature/cnn, feature/cnn_org, feature/constantq, feature/crepe, feature/crepe_org, feature/pitchshift, feature/pydocstrings, feature/timestretch, fix/ffmpeg5, master, pitchshift, sampler, timestretch, yinfft+

Children:

13e23b8

Parents:

cf2f1b8

Message:

src/mathutils.c: change zero crossing function to split at >=0/<0; tests/python/src/temporal/zero_crossing_rate.py: add some tests for zero crossing

Files:

• src/mathutils.c (modified) (1 diff)
• tests/python/src/temporal/zero_crossing_rate.py (added)

src/mathutils.c

@@ -420 +420 @@
   uint_t zcr = 0;
   for ( j = 1; j < input->length; j++ ) {
-    // previous was negative
-    if( input->data[i][j-1] <= 0. ) {
-      if ( input->data[i][j] > 0. ) {
+    // previous was strictly negative
+    if( input->data[i][j-1] < 0. ) {
+      // current is positive or null
+      if ( input->data[i][j] >= 0. ) {
         zcr += 1;
       }
-    //previous was positive
-    } else if ( input->data[i][j] <= 0. ) {
-      zcr += 1;
+    // previous was positive or null
+    } else {
+      // current is strictly negative
+      if ( input->data[i][j] < 0. ) {
+        zcr += 1;
+      }
     }
   }