Changeset a77f0c6 for src

Timestamp:

Dec 7, 2018, 1:28:57 AM (6 years ago)

Author:

Paul Brossier <piem@piem.org>

Branches:

feature/cnn, feature/crepe, feature/timestretch, fix/ffmpeg5, master

Children:

4bb2e74

Parents:

24dc867

git-author:

Paul Brossier <piem@piem.org> (10/27/18 19:39:55)

git-committer:

Paul Brossier <piem@piem.org> (12/07/18 01:28:57)

Message:

[effects] convert warnings to error, improve messages

Location:

src/effects

Files:

• pitchshift_rubberband.c (modified) (2 diffs)
• timestretch_rubberband.c (modified) (5 diffs)

src/effects/pitchshift_rubberband.c

@@ -114 +114 @@
     return AUBIO_OK;
   } else {
-    AUBIO_ERR("pitchshift: could not set pitchscale to %.2f\n", pitchscale);
+    AUBIO_ERR("pitchshift: could not set pitchscale to '%f',"
+        " should be in the range [0.25, 4.].\n", pitchscale);
     return AUBIO_FAIL;
   }
@@ -132 +133 @@
     return aubio_pitchshift_set_pitchscale(p, pitchscale);
   } else {
-    AUBIO_ERR("pitchshift: could not set transpose to %.2f\n", transpose);
+    AUBIO_ERR("pitchshift: could not set transpose to '%f',"
+        " should be in the range [-24; 24.].\n", transpose);
     return AUBIO_FAIL;
   }

src/effects/timestretch_rubberband.c

@@ -131 +131 @@
 {
   if (!p->rb) {
-    AUBIO_WRN("timestretch: could not set stretch ratio, rubberband not created\n");
+    AUBIO_ERR("timestretch: could not set stretch ratio,"
+       " rubberband not created\n");
     return AUBIO_FAIL;
   }
@@ -139 +140 @@
     return AUBIO_OK;
   } else {
-    AUBIO_WRN("timestretch: could not set stretch ratio to %.2f\n", stretch);
+    AUBIO_ERR("timestretch: could not set stretch ratio to '%f',"
+        " should be in the range [%.2f, %.2f].\n", stretch,
+        MIN_STRETCH_RATIO, MAX_STRETCH_RATIO);
     return AUBIO_FAIL;
   }
@@ -154 +157 @@
 {
   if (!p->rb) {
-    AUBIO_WRN("timestretch: could not set pitch scale, rubberband not created\n");
+    AUBIO_ERR("timestretch: could not set pitch scale,"
+       " rubberband not created\n");
     return AUBIO_FAIL;
   }
@@ -162 +166 @@
     return AUBIO_OK;
   } else {
-    AUBIO_WRN("timestretch: could not set pitchscale to %.2f\n", pitchscale);
+    AUBIO_ERR("timestretch: could not set pitchscale to '%f',"
+        " should be in the range [0.0625, 4.].\n", pitchscale);
     return AUBIO_FAIL;
   }
@@ -180 +185 @@
     return aubio_timestretch_set_pitchscale(p, pitchscale);
   } else {
-    AUBIO_WRN("timestretch: could not set transpose to %.2f\n", transpose);
+    AUBIO_ERR("timestretch: could not set transpose to '%f',"
+        " should be in the range [-24; 24].\n", transpose);
     return AUBIO_FAIL;
   }