Changeset de0a492

Timestamp:

May 3, 2016, 4:19:28 AM (9 years ago)

Author:

Paul Brossier <piem@piem.org>

Branches:

feature/autosink, feature/cnn, feature/cnn_org, feature/constantq, feature/crepe, feature/crepe_org, feature/pitchshift, feature/pydocstrings, feature/timestretch, fix/ffmpeg5, master, pitchshift, sampler, timestretch, yinfft+

Children:

fcef3fd

Parents:

7aed123

Message:

python/ext/py-filterbank.c: check input size

Location:

python

Files:

• ext/py-filterbank.c (modified) (1 diff)
• tests/test_filterbank.py (modified) (1 diff)

python/ext/py-filterbank.c

@@ -90 +90 @@
 
   if (!PyAubio_PyCvecToCCvec(input, &(self->vec) )) {
+    return NULL;
+  }
+
+  if (self->vec.length != self->win_s / 2 + 1) {
+    PyErr_Format(PyExc_ValueError,
+                 "input cvec has length %d, but fft expects length %d",
+                 self->vec.length, self->win_s / 2 + 1);
     return NULL;
   }

python/tests/test_filterbank.py

@@ -62 +62 @@
         assert_almost_equal ( expected, f.get_coeffs() )
 
+    def test_filterbank_long_cvec(self):
+        f = filterbank(40, 512)
+        with self.assertRaises(ValueError):
+            f(cvec(1024))
+
+    def test_filterbank_short_cvec(self):
+        f = filterbank(40, 512)
+        with self.assertRaises(ValueError):
+            f(cvec(256))
+
 if __name__ == '__main__':
     from nose2 import main