Bug in aubio-0.3.2 mathutils.c (silence_detection)

[epalace@gmail.com]

Hi,

I think I found a bug in mathutils.c about the calculation of the RMS power dBs involving lines : 417,418 and 433,434 :

loudness = SQRT(loudness); loudness /= (smpl_t)ibuf->length;

The división by the buffer length should be done before the sqrt :

loudness = SQRT(loudness/(smpl_t)ibuf->length))

I found this bug because I was getting pretty low dBs values, and even using a full-power square wave I was getting levels below 0 dBs

Ah, in addition, this code can be optimized removing the SQRT , and using 10*log10f instead of 20*log10f

Regards,

Eric.

[Paul Brossier]

Hi Eric,

Wow, that's a pretty bad one indeed, thanks for noticing.

Paul

[Paul Brossier]

closed in 1a74ac3c0d8a